tokyo-night theme uses tokyo-storm palette

[adrian5]

With the exception of the background, the colors of tokyo-night are a copy of tokyo-storm.

It would be nice to have the higher-contrast moon and night variants. You can see the original Tokyo Night theme variants here. I've looked around in this repository, but it's not apparent to me how to contribute themes (I assume there's some build step), so here a request instead.

Thanks!

[fdncred]

We'd accept a PR for this.

[adrian5]

I would if I knew how. It seems the make.nu script is hardcoded for a specific remote repository and fails if I point it to my fork. Since it overwrites any local changes with a cloned repo, that won't work either.

[amtoine]

@adrian5
why would it fail with a fork?

also, that's how i wrote the script in the first place to avoid having to write a whole bunch of themes myself, but if there is a better solution somewhere, it could be nice 😋

[adrian5]

@adrian5 why would it fail with a fork?

My bad, it fails when pointing SOURCE { remote: … } to a non-default branch. I moved the changes in my fork to master and that worked.

also, that's how i wrote the script in the first place to avoid having to write a whole bunch of themes myself, but if there is a better solution somewhere, it could be nice 😋

Fair enough. I think one hindrance to contributions is that this hinges on the lemnos repo staying maintained, which I'm not sure it is.

---

Anyway, as mentioned I was now able to build the nushell theme file. Can I just add it to themes/nu-themes as a PR and someone else commits a screenshot afterwards?

[amtoine]

My bad, it fails when pointing SOURCE { remote: … } to a non-default branch. I moved the changes in my fork to master and that worked.

ooh i see 👌

Fair enough. I think one hindrance to contributions is that this hinges on the lemnos repo staying maintained, which I'm not sure it is.

also more than fair 😉

Anyway, as mentioned I was now able to build the nushell theme file. Can I just add it to themes/nu-themes as a PR and someone else commits a screenshot afterwards?

there might be a script for the screenshots, not sure
@fdncred probably knows 😋

[fdncred]

we can have a pr without a screenshot. yes, there are scripts to generate screenshots. i ran them on windows.

[adrian5]

Alright! I saw the scripts (the screenshot link points there) but currently don't have a Windows installation available. Will do a PR and then close this.