Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Basic Flake (#41)" #52

Closed
wants to merge 1 commit into from
Closed

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Sep 28, 2023

related to

cc/ @IogaMaster

Description of changes

this PR reverts #41.

without any justification for this, i'd rather revert the changes 😋
i'm still having issues understanding what this does and why we need that in Nufmt when we don't even have a working MVP of the formatter itself 🤔

@amtoine amtoine marked this pull request as draft September 28, 2023 16:23
@IogaMaster
Copy link
Contributor

Simple setup of a reproducable development environment, same version of rust toolchain and nushell for development.
As well as simple remote testing.
With nix run: nix run github:nushell/nufmt and the version on main will be built without any installation of rust.

Also makes this package play with nix better. Making packaging in nixpkgs simple.

@amtoine
Copy link
Member Author

amtoine commented Sep 29, 2023

i get it but my main question remains: do we need to have that in nufmt?

it's just that i personally do not know anything about all this, even though i really want to try NixOS, and we already have #53 but i'm not sure we have anyone to answer this 😕

@IogaMaster
Copy link
Contributor

It's not integrated into nufmt, it's around to make working on it easier.

One other thing, we can cross compile nufmt for any platform and architecture. Which make building github releases ci easier.

@amtoine
Copy link
Member Author

amtoine commented Sep 30, 2023

could we put these files into a nix/ directory at the root of the repo? 😇
consider me as a total newbie when it comes to nix 😌

@IogaMaster
Copy link
Contributor

Unfortunately the flake.nix must go in the root of the repo. That is the standard for flakes.

@fdncred
Copy link
Collaborator

fdncred commented Sep 30, 2023

I don't see what the problem is. Who cares that there is a flake.nix/.lock file in the root of the repo. It just helps people who use nix to be able to test/use it. It seems like a big waste of time to debate trivial changes like this.

@amtoine
Copy link
Member Author

amtoine commented Oct 1, 2023

thanks @IogaMaster for explaining why these have been added the way they have been 🙏

@amtoine amtoine closed this Oct 1, 2023
@amtoine amtoine deleted the revert-41 branch October 1, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants