Modifier for altgr #139
Merged
Modifier for altgr #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiajt
reviewed
Sep 4, 2021
| @@ -33,6 +33,9 @@ impl EditMode for Emacs { | |||
| | (KeyModifiers::SHIFT, KeyCode::Char(c)) => { | |||
| ReedlineEvent::EditInsert(EditCommand::InsertChar(c)) | |||
| } | |||
| (m, KeyCode::Char(c)) if m == KeyModifiers::CONTROL | KeyModifiers::ALT => { | |||
There was a problem hiding this comment.
Since we look for Ctrl+c a few lines above this one, should we just look for ALT here?
There was a problem hiding this comment.
The thing is that in my keyboard the key alt gr appear as a mixed KeyModifier called CONTROL | ALT. This isnt a Control or Alt situation, it has to be both
There was a problem hiding this comment.
Oooh as a bitwise operation. Got it. I totally misread that this morning.
|
Just fixed CI for reedline, so in theory the next change should pick it up |
…to altgr-keymodifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added clause to consider special modifier for non english keyboards