This repository has been archived by the owner on Dec 28, 2017. It is now read-only.
Fix parser for examTimetable #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangshun
approved these changes
Nov 5, 2016
|
|
||
| const fileArray = new Uint8Array(fileData); | ||
| return pdfjs.getDocument(fileArray) | ||
| .then((pdfDocument) => { |
There was a problem hiding this comment.
If we're gna use es6 for our parses then we better specify a node version in .nvmrc
| // get text content items from all pages | ||
| return Promise.all(pages.map((page) => { | ||
| return page.getTextContent().then((content) => { | ||
| return content.items.slice(17, -1); // remove page numbers |
There was a problem hiding this comment.
Can explain what 17 is? Try to reduce magic numbers.
| // first 21 chars contain the date and time | ||
| const dateTime = moduleString.substr(-21).split(')'); | ||
| // only keep numerics | ||
| const date = dateTime[0].replace(/\D/g,''); |
| const time = dateTime[1]; | ||
|
|
||
| // remove date and time to parse module faculty, code and name | ||
| moduleArr.splice(-8, 8); |
| helpers.requestCached('https://webrb.nus.edu.sg/examtt/Exam' + options.academicYear.slice(0, 4) + | ||
| '/Semester ' + options.semester + '/MASTER Sem ' + | ||
| options.semester + ' by Module.html', options, function (err, data) { | ||
| var url = 'https://webrb.nus.edu.sg/examtt/Exam' + options.academicYear.slice(0, 4) + |
There was a problem hiding this comment.
How about using es6 template strings?
|
Can squash and merge if it's ready. Would be better if can squash, rebase then ff merge but Github doesn't provide that option out of the box :( |
Add .nvmrc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So NUS decided to use pdfs instead and this parses the pdfs. Also a change to requestCache by enabling caching of binary files.