Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make report course error button more prominent coursereg / course update periods #3784

Open
kokrui opened this issue Aug 20, 2024 · 1 comment

Comments

@kokrui
Copy link
Member

kokrui commented Aug 20, 2024

On each course detail page, below the "Add to Semester X", there is a "Report Errors" button which directs users to the correct faculty / department email to contact.

image

I'm not sure if many people notice / use this button right now, but I think it's helpful as another prompt to inform NUSMods users that they should be going to their faculties / departments instead of contacting the maintainers for issues related to course data.

To that end, we could upgrade the visibility of the button either when CourseReg is active (maybe +- a week), and/or when course information is newly-updated.

One can detect the former using the dates from https://github.com/nusmodifications/nusmods/blob/master/website/src/data/modreg-schedule.json,

and the latter by seeing if the relevant announcement is enabled (

const enableAnnouncements = true;
/**
* Unique key for the current announcement. If the announcement is not
* dismissible, set the key to null. Otherwise, set it to a string.
*
* Previous keys:
* - 'ay202425-new-data' - AY2024/25 data is available
* - 'ay202324-new-data' - AY2023/24 data is available
* - 'ay202223-new-data' - AY2022/23 data is available
* - 'vercel-migration-120522' - Announcement for possible outage for
* migration out of Vercel team plan
* - 'ay202122-2107-search-outage' - Module search outage apology
* - 'ay202122-new-data' - AY2021/22 data is available
* - 'ay202021-new-data' - AY2020/21 data is available
* - 'ay201920-new-data' - AY2019/20 data is available
* - 'nusmods-is-official' - NUSMods switch to official APIs
* - 'nusmods-r-announcement' - NUSMods R announcement message
* - 'ay201819-new-data' - AY2018/19 data is available
* - 'ay201819-s2-new-data' - S2 data available
*/
const key = announcementKey('ay202425-new-data');
)

Perhaps we can improve the visibility of the button during those periods by giving it a border, letting it span across the course description, or anything else you think of.

@KieronOei
Copy link

I'd like to work on this

@jloh02 jloh02 added the taken label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants