Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added color palette feature for Wrapper #2

Closed
wants to merge 2 commits into from

Conversation

fers4t
Copy link
Contributor

@fers4t fers4t commented Mar 15, 2022

I think this feature might be useful if users want to use their own color palette.

@nusu
Copy link
Owner

nusu commented Mar 15, 2022

That's a bit problematic...
So if we are going that way, both Background and Foreground colors should be editable.
Also, the length of Foreground colors and Background colors should be equal otherwise plugin has to throw an error.

Enabling this, will dramatically reduce the chance of creating unique combinations, yet people might want to edit colors to their brand colors, that's totally understandable.

Thank you for your contributions, I'm going to think about that.

@fers4t
Copy link
Contributor Author

fers4t commented Mar 15, 2022

This is right.
We can use tinycolor2 to play with colors and give avatars a good look.
But I don't know if it's worth ✌🏻

@nusu nusu closed this Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants