Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Combine generic variables with provider specific variables #173

Merged
merged 4 commits into from
Sep 25, 2023
Merged

feat: Combine generic variables with provider specific variables #173

merged 4 commits into from
Sep 25, 2023

Conversation

jimmidyson
Copy link
Member

@jimmidyson jimmidyson commented Sep 22, 2023 •
edited
Loading

  1. Combine generic variables with provider specific variables, leading to a
    single variable per provider. This is provided by a separate discover
    variables hook per provider that will have to be referenced by name in the
    clusterclass.
  2. The name of this single variable will always be clusterConfig regardless of
    provider, but 1 will ensure that this variable has only the relevant fields
    for the cluster provider. Having the same variable name gives a consistent
    feel across providers.
  3. Remove registration of individual patches and only keep meta patches. This
    simplifies things. We keep the implementations separate for better
    testability and also to allow for inclusion in other libraries.

Depends on #172 .

Base automatically changed from jimmi/aws-patch to main September 22, 2023 15:59
@github-actions
Copy link
Contributor

This PR/issue depends on:

@jimmidyson
feat: Combine generic variables with provider specific variables
9b00c5e 
1. Combine generic variables with provider specific variables, leading to a
   single variable per provider. This will be provided by a separate discover
   variables hook per provider that will have to be referenced by name in the
   clusterclass.
2. The name of this single variable will always be clusterConfig regardless of
   provider, but 1 will ensure that this variable has only the relevant fields
   for the cluster provider. Having the same variable name gives a consistent
   feel across providers.
3. Remove registration of individual patches and only keep meta patches. This
   simplifies things. We keep the implementations separate for better
   testability and also to allow for inclusion in other libraries.
@github-actions github-actions bot added feature and removed feature labels Sep 22, 2023
dkoshkin
dkoshkin previously approved these changes Sep 22, 2023
View reviewed changes
@dkoshkin dkoshkin force-pushed the jimmi/combine-provider-patches branch from 80de37b to 2facd2a Compare September 22, 2023 19:24
@dkoshkin dkoshkin force-pushed the jimmi/combine-provider-patches branch from 2facd2a to f502212 Compare September 22, 2023 19:28
@dkoshkin dkoshkin dismissed their stale review September 22, 2023 20:07

Going to manually test again, it was failing for a Docker cluster.

@jimmidyson jimmidyson enabled auto-merge (squash) September 25, 2023 11:43
@jimmidyson jimmidyson merged commit 2c66a05 into main Sep 25, 2023
10 checks passed
@jimmidyson jimmidyson deleted the jimmi/combine-provider-patches branch September 25, 2023 12:00
@github-actions github-actions bot mentioned this pull request Sep 22, 2023
Merged
dkoshkin pushed a commit that referenced this pull request Oct 19, 2023
@github-actions
build(main): release 0.2.0 (#170)
0bccd2d 
🤖 I have created a release *beep* *boop*
---


## 0.2.0 (2023-10-19)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: AWS cluster config patch by @jimmidyson in
#172
* feat: Combine generic variables with provider specific variables by
@jimmidyson in
#173
* feat: Use external patch for Docker provider custom image by
@jimmidyson in
#188
* feat: vendor infrastructure provider APIs by @dkoshkin in
#190
* feat: Introduce scheme and decoder helpers by @jimmidyson in
#191
* feat: add imageRegistryCredentials handler by @dkoshkin in
#174
* feat: Deploy default clusterclasses via helm by @jimmidyson in
#198
* feat: Add Calico CNI AWS ingress rules by @jimmidyson in
#206
* feat: CAPA v2.2.4 by @jimmidyson in
#211
* feat: Add worker configs var and handler by @dkoshkin in
#208
* feat: adds aws ebs config by @faiq in
#192
* feat: add AWS IAM instance profile patch by @dkoshkin in
#216
* feat: Calico 3.26.3 by @jimmidyson in
#218
* feat: add AWS instance type patch by @dkoshkin in
#217
* feat: variables and patches for AWS AMI spec by @supershal in
#225
* feat: add VPC ID and Subnet IDs patch by @dkoshkin in
#220
* feat: deploy AWS CPI by @faiq in
#229
### Fixes 🔧
* fix: bring back missing docker handlers by @dkoshkin in
#187
* fix: typo in docker cluster config api by @supershal in
#205
* fix: move provider fields under aws and docker by @dkoshkin in
#204
* fix: Correctly set external cloud provider for AWS by @jimmidyson in
#210
* fix: Adds AWS Calico installation configmap by @jimmidyson in
#212
* fix: Ensure CNI ingress rules are added to AWSCluster by @jimmidyson
in #213
* fix: Reduce log verbosity for http proxy variable not found by
@jimmidyson in
#214
* fix: Don't set AWS region as required by @dkoshkin in
#219
### Other Changes
* build: Add example files to release artifacts by @jimmidyson in
#169
* build: Add AWS clusterclass example by @jimmidyson in
#162
* refactor: Move generic handlers into generic directory by @jimmidyson
in #171
* ci: Simplify shell configuration by setting defaults by @jimmidyson in
#184
* build: Disable fortify hardener to enable local debugging by
@jimmidyson in
#186
* docs: Add more details about single var by @jimmidyson in
#185
* refactor: Move meta handlers to provider packages by @jimmidyson in
#193
* refactor: Use consistent decoder in mutators by @jimmidyson in
#196
* build: Suppress devbox envrc update notification by @jimmidyson in
#197
* build: Consistent behaviour in addons update scripts by @jimmidyson in
#207
* build: Allow past year in license header by @jimmidyson in
#209
* build: Increase golangci-lint timeout for slower GHA runners by
@jimmidyson in
#222
* refactor: Always use unstructured in patch generators by @jimmidyson
in #221
* build: Update tools by @jimmidyson in
#223
* refactor: Remove usage of non-meta handlers by @dkoshkin in
#226

## New Contributors
* @supershal made their first contribution in
#205

**Full Changelog**:
v0.1.2...v0.2.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoshkin dkoshkin dkoshkin approved these changes

@faiq faiq Awaiting requested review from faiq

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jimmidyson @dkoshkin