Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add VPC ID and Subnet IDs patch #220

Merged
merged 2 commits into from
Oct 17, 2023
Merged

feat: add VPC ID and Subnet IDs patch #220

merged 2 commits into from
Oct 17, 2023

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Oct 10, 2023 •
edited
Loading

Fixes #201
Fixes #200

Depends on #219

Tested manually (at-least that the values are set in AWSCluster)

apiVersion: cluster.x-k8s.io/v1beta1
kind: Cluster
metadata:
  name: <NAME>
spec:
  topology:
    variables:
      - name: clusterConfig
        value:
          aws:
            network:
              vpc:
                id: vpc-1234567890
              subnets:
                - id: subnet-1
                - id: subnet-2
                - id: subnet-3

This is what the AWSCluster looked like:

  spec:
    network:
      subnets:
      - id: subnet-1
        isPublic: false
      - id: subnet-2
        isPublic: false
      - id: subnet-3
        isPublic: false
      vpc:
        availabilityZoneSelection: Ordered
        availabilityZoneUsageLimit: 3
        id: vpc-1234567890
    region: us-west-2

Base automatically changed from dkoshkin/fix-region-not-required to main October 11, 2023 15:25
@github-actions
Copy link
Contributor

This PR/issue depends on:

@github-actions github-actions bot added feature and removed feature labels Oct 16, 2023
@dkoshkin dkoshkin force-pushed the dkoshkin/feat-vpc-id-subnets branch 2 times, most recently from b1be52f to b806332 Compare October 16, 2023 18:42
@dkoshkin dkoshkin mentioned this pull request Oct 16, 2023
Merged
supershal
supershal approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@supershal supershal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. except a nit

@dkoshkin dkoshkin enabled auto-merge (squash) October 17, 2023 14:18
@dkoshkin dkoshkin merged commit 349bf97 into main Oct 17, 2023
10 checks passed
@dkoshkin dkoshkin deleted the dkoshkin/feat-vpc-id-subnets branch October 17, 2023 14:26
@github-actions github-actions bot mentioned this pull request Oct 17, 2023
Merged
dkoshkin pushed a commit that referenced this pull request Oct 19, 2023
@github-actions
build(main): release 0.2.0 (#170)
0bccd2d 
🤖 I have created a release *beep* *boop*
---


## 0.2.0 (2023-10-19)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: AWS cluster config patch by @jimmidyson in
#172
* feat: Combine generic variables with provider specific variables by
@jimmidyson in
#173
* feat: Use external patch for Docker provider custom image by
@jimmidyson in
#188
* feat: vendor infrastructure provider APIs by @dkoshkin in
#190
* feat: Introduce scheme and decoder helpers by @jimmidyson in
#191
* feat: add imageRegistryCredentials handler by @dkoshkin in
#174
* feat: Deploy default clusterclasses via helm by @jimmidyson in
#198
* feat: Add Calico CNI AWS ingress rules by @jimmidyson in
#206
* feat: CAPA v2.2.4 by @jimmidyson in
#211
* feat: Add worker configs var and handler by @dkoshkin in
#208
* feat: adds aws ebs config by @faiq in
#192
* feat: add AWS IAM instance profile patch by @dkoshkin in
#216
* feat: Calico 3.26.3 by @jimmidyson in
#218
* feat: add AWS instance type patch by @dkoshkin in
#217
* feat: variables and patches for AWS AMI spec by @supershal in
#225
* feat: add VPC ID and Subnet IDs patch by @dkoshkin in
#220
* feat: deploy AWS CPI by @faiq in
#229
### Fixes 🔧
* fix: bring back missing docker handlers by @dkoshkin in
#187
* fix: typo in docker cluster config api by @supershal in
#205
* fix: move provider fields under aws and docker by @dkoshkin in
#204
* fix: Correctly set external cloud provider for AWS by @jimmidyson in
#210
* fix: Adds AWS Calico installation configmap by @jimmidyson in
#212
* fix: Ensure CNI ingress rules are added to AWSCluster by @jimmidyson
in #213
* fix: Reduce log verbosity for http proxy variable not found by
@jimmidyson in
#214
* fix: Don't set AWS region as required by @dkoshkin in
#219
### Other Changes
* build: Add example files to release artifacts by @jimmidyson in
#169
* build: Add AWS clusterclass example by @jimmidyson in
#162
* refactor: Move generic handlers into generic directory by @jimmidyson
in #171
* ci: Simplify shell configuration by setting defaults by @jimmidyson in
#184
* build: Disable fortify hardener to enable local debugging by
@jimmidyson in
#186
* docs: Add more details about single var by @jimmidyson in
#185
* refactor: Move meta handlers to provider packages by @jimmidyson in
#193
* refactor: Use consistent decoder in mutators by @jimmidyson in
#196
* build: Suppress devbox envrc update notification by @jimmidyson in
#197
* build: Consistent behaviour in addons update scripts by @jimmidyson in
#207
* build: Allow past year in license header by @jimmidyson in
#209
* build: Increase golangci-lint timeout for slower GHA runners by
@jimmidyson in
#222
* refactor: Always use unstructured in patch generators by @jimmidyson
in #221
* build: Update tools by @jimmidyson in
#223
* refactor: Remove usage of non-meta handlers by @dkoshkin in
#226

## New Contributors
* @supershal made their first contribution in
#205

**Full Changelog**:
v0.1.2...v0.2.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dkoshkin added a commit that referenced this pull request Nov 9, 2023
@dkoshkin
feat: add control-plane load balancer scheme patch (#228)
72780f6 
Fixes #202

Depends on #220

Tested manually setting the `internal`
```
  spec:
    bastion:
      allowedCIDRBlocks:
      - 0.0.0.0/0
      enabled: false
    controlPlaneEndpoint:
      host: ""
      port: 0
    controlPlaneLoadBalancer:
      crossZoneLoadBalancing: false
      loadBalancerType: classic
      scheme: internal
```
@github-actions github-actions bot mentioned this pull request Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supershal supershal supershal approved these changes

@jimmidyson jimmidyson Awaiting requested review from jimmidyson

@faiq faiq Awaiting requested review from faiq

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patch: AWS VPC ID Patch: AWS Subnet IDs
2 participants
@dkoshkin @supershal