feat: Add worker configs var and handler

[dkoshkin]

This adds code to set worker overrides to clusterConfig, here is an example of how to use it:

apiVersion: cluster.x-k8s.io/v1beta1
kind: Cluster
metadata:
  name: <NAME>
spec:
    topology:
      class: docker-quick-start
      controlPlane:
        metadata: {}
        replicas: 1
      variables:
      - name: clusterConfig
        value:
          addons:
            cni:
              provider: calico
            nfd: {}
          controlPlane:
            docker:
              customImage: ghcr.io/mesosphere/kind-node:v1.2.3-cp
          docker: {}
      - name: workerConfig
        value:
          docker:
            customImage: ghcr.io/mesosphere/kind-node:v1.2.3-worker
      version: v1.27.5
      workers:
        machineDeployments:
        - class: default-worker
          metadata: {}
          name: md-0
          replicas: 1
        - class: default-worker
          metadata: {}
          name: md-1
          replicas: 1
          variables:
            overrides:
            - name: workerConfig
              value:
                docker:
                  customImage: ghcr.io/mesosphere/kind-node:v1.2.3-custom

[dkoshkin]

@supershal this may be useful to look at for #199

[dkoshkin]

Ok moving workerConfig to a separate variable really simplified it, working as expected:

    topology:
      class: docker-quick-start
      controlPlane:
        metadata: {}
        replicas: 1
      variables:
      - name: clusterConfig
        value:
          addons:
            cni:
              provider: calico
            nfd: {}
          controlPlane:
            docker:
              customImage: ghcr.io/mesosphere/kind-node:v1.2.3-cp
          docker: {}
      - name: workerConfig
        value:
          docker:
            customImage: ghcr.io/mesosphere/kind-node:v1.2.3-worker
      version: v1.27.5
      workers:
        machineDeployments:
        - class: default-worker
          metadata: {}
          name: md-0
          replicas: 1
        - class: default-worker
          metadata: {}
          name: md-1
          replicas: 1
          variables:
            overrides:
            - name: workerConfig
              value:
                docker:
                  customImage: ghcr.io/mesosphere/kind-node:v1.2.3-custom

- apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
  kind: DockerMachineTemplate
  metadata:
    name: docker-quick-start-control-plane-pqkd9
    namespace: default
  spec:
    template:
      spec:
        customImage: ghcr.io/mesosphere/kind-node:v1.2.3-cp
        extraMounts:
        - containerPath: /var/run/docker.sock
          hostPath: /var/run/docker.sock
- apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
  kind: DockerMachineTemplate
  metadata:
    name: docker-quick-start-md-0-infra-9526d
    namespace: default
  spec:
    template:
      spec:
        customImage: ghcr.io/mesosphere/kind-node:v1.2.3-worker
        extraMounts:
        - containerPath: /var/run/docker.sock
          hostPath: /var/run/docker.sock
- apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
  kind: DockerMachineTemplate
  metadata:
    name: docker-quick-start-md-1-infra-b5cjx
    namespace: default
  spec:
    template:
      spec:
        customImage: ghcr.io/mesosphere/kind-node:v1.2.3-custom
        extraMounts:
        - containerPath: /var/run/docker.sock
          hostPath: /var/run/docker.sock

[jimmidyson]

Nice! I won't be able to review or try this out until Monday so help from @supershal or @faiq would be great to get this merged 🙏

[supershal]

Nice! I won't be able to review or try this out until Monday so help from @supershal or @faiq would be great to get this merged 🙏

me and @dkoshkin just go over the PR code changes this morning. changes looks good. I will test it locally before approving it today.

[supershal]

@dkoshkin should we remove [region/variables.go] in mutation package (https://github.com/d2iq-labs/capi-runtime-extensions/blob/main/pkg/handlers/aws/mutation/region/variables.go) and its test file with this change?

and same for the docker custom Image in the mutation package.

[dkoshkin]

@dkoshkin should we remove region/variables.go and its test file with this change?

I don't think so @supershal , that configuration is still valid. Are you seeing something in this PR that made you think that?

[supershal]

the awsRegionVariableHandler and customImageVariableHandler are not registered anymore. their unit testing is covered by test in the clusterconfig package. https://github.com/d2iq-labs/capi-runtime-extensions/blob/main/pkg/handlers/aws/clusterconfig/variables_test.go

[dkoshkin]

the awsRegionVariableHandler and customImageVariableHandler are not registered anymore. their unit testing is covered by test in the clusterconfig package. https://github.com/d2iq-labs/capi-runtime-extensions/blob/main/pkg/handlers/aws/clusterconfig/variables_test.go

Lets do that in a separate PR, we could do this cleanup in all handlers not just these two.