Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add AWS IAM instance profile patch #216

Merged
merged 4 commits into from
Oct 9, 2023
Merged

feat: add AWS IAM instance profile patch #216

merged 4 commits into from
Oct 9, 2023

Conversation

dkoshkin
Copy link
Collaborator

@dkoshkin dkoshkin commented Oct 6, 2023

New AWS patch for control-plane and worker machines

Tested creating a cluster:

- apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
  kind: AWSMachineTemplate
  metadata:
    name: aws-quick-start-control-plane-pgg9l
    namespace: default
  spec:
    template:
      spec:
        iamInstanceProfile: custom-control-plane.cluster-api-provider-aws.sigs.k8s.io
        instanceType: m5.xlarge
- apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
  kind: AWSMachineTemplate
    name: aws-quick-start-md-0-infra-jkwdz
    namespace: default
  spec:
    template:
      spec:
        iamInstanceProfile: custom-nodes.cluster-api-provider-aws.sigs.k8s.io
        instanceType: m5.2xlarge

@dkoshkin dkoshkin force-pushed the dkoshkin/feat-aws-instance-profile branch 2 times, most recently from 4c360d3 to a65d0ad Compare October 6, 2023 14:43
@dkoshkin
feat: add AWS IAM instance profile patch
828b1ca
@dkoshkin
refactor: remove unnecessary tests
ba3bf6f 
These are not needed and just add more code, lets rely on the meta tests
@dkoshkin dkoshkin force-pushed the dkoshkin/feat-aws-instance-profile branch from bdcf565 to ba3bf6f Compare October 6, 2023 16:51
@dkoshkin dkoshkin mentioned this pull request Oct 6, 2023
Merged
@dkoshkin
fix: typos in docs
bf04e45 
Co-authored-by: Shalin Patel <spatel@d2iq.com>
Signed-off-by: Dimitri Koshkin <dimitri.koshkin@gmail.com>
@dkoshkin dkoshkin enabled auto-merge (squash) October 9, 2023 15:55
@dkoshkin dkoshkin merged commit 572735b into main Oct 9, 2023
10 checks passed
@dkoshkin dkoshkin deleted the dkoshkin/feat-aws-instance-profile branch October 9, 2023 16:00
@github-actions github-actions bot mentioned this pull request Oct 9, 2023
Merged
dkoshkin added a commit that referenced this pull request Oct 10, 2023
@dkoshkin
feat: add AWS instance type patch (#217)
a94f380 
Depends on #216

Tested manually:
```
- apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
  kind: AWSMachineTemplate
  metadata:
    name: aws-quick-start-control-plane-dlj45
    namespace: default
    template:
      spec:
        iamInstanceProfile: control-plane.cluster-api-provider-aws.sigs.k8s.io
        instanceType: m5.2xlarge
- apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
  kind: AWSMachineTemplate
metadata
    name: aws-quick-start-md-0-infra-kpc8m
    namespace: default
  spec:
    template:
      spec:
        iamInstanceProfile: nodes.cluster-api-provider-aws.sigs.k8s.io
        instanceType: m5.4xlarge
```
dkoshkin pushed a commit that referenced this pull request Oct 19, 2023
@github-actions
build(main): release 0.2.0 (#170)
0bccd2d 
🤖 I have created a release *beep* *boop*
---


## 0.2.0 (2023-10-19)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: AWS cluster config patch by @jimmidyson in
#172
* feat: Combine generic variables with provider specific variables by
@jimmidyson in
#173
* feat: Use external patch for Docker provider custom image by
@jimmidyson in
#188
* feat: vendor infrastructure provider APIs by @dkoshkin in
#190
* feat: Introduce scheme and decoder helpers by @jimmidyson in
#191
* feat: add imageRegistryCredentials handler by @dkoshkin in
#174
* feat: Deploy default clusterclasses via helm by @jimmidyson in
#198
* feat: Add Calico CNI AWS ingress rules by @jimmidyson in
#206
* feat: CAPA v2.2.4 by @jimmidyson in
#211
* feat: Add worker configs var and handler by @dkoshkin in
#208
* feat: adds aws ebs config by @faiq in
#192
* feat: add AWS IAM instance profile patch by @dkoshkin in
#216
* feat: Calico 3.26.3 by @jimmidyson in
#218
* feat: add AWS instance type patch by @dkoshkin in
#217
* feat: variables and patches for AWS AMI spec by @supershal in
#225
* feat: add VPC ID and Subnet IDs patch by @dkoshkin in
#220
* feat: deploy AWS CPI by @faiq in
#229
### Fixes 🔧
* fix: bring back missing docker handlers by @dkoshkin in
#187
* fix: typo in docker cluster config api by @supershal in
#205
* fix: move provider fields under aws and docker by @dkoshkin in
#204
* fix: Correctly set external cloud provider for AWS by @jimmidyson in
#210
* fix: Adds AWS Calico installation configmap by @jimmidyson in
#212
* fix: Ensure CNI ingress rules are added to AWSCluster by @jimmidyson
in #213
* fix: Reduce log verbosity for http proxy variable not found by
@jimmidyson in
#214
* fix: Don't set AWS region as required by @dkoshkin in
#219
### Other Changes
* build: Add example files to release artifacts by @jimmidyson in
#169
* build: Add AWS clusterclass example by @jimmidyson in
#162
* refactor: Move generic handlers into generic directory by @jimmidyson
in #171
* ci: Simplify shell configuration by setting defaults by @jimmidyson in
#184
* build: Disable fortify hardener to enable local debugging by
@jimmidyson in
#186
* docs: Add more details about single var by @jimmidyson in
#185
* refactor: Move meta handlers to provider packages by @jimmidyson in
#193
* refactor: Use consistent decoder in mutators by @jimmidyson in
#196
* build: Suppress devbox envrc update notification by @jimmidyson in
#197
* build: Consistent behaviour in addons update scripts by @jimmidyson in
#207
* build: Allow past year in license header by @jimmidyson in
#209
* build: Increase golangci-lint timeout for slower GHA runners by
@jimmidyson in
#222
* refactor: Always use unstructured in patch generators by @jimmidyson
in #221
* build: Update tools by @jimmidyson in
#223
* refactor: Remove usage of non-meta handlers by @dkoshkin in
#226

## New Contributors
* @supershal made their first contribution in
#205

**Full Changelog**:
v0.1.2...v0.2.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supershal supershal supershal approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dkoshkin @supershal