Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: Support for signing commits #33

Closed
kdpuvvadi opened this issue Feb 15, 2023 · 4 comments · Fixed by #70
Closed

RFE: Support for signing commits #33

kdpuvvadi opened this issue Feb 15, 2023 · 4 comments · Fixed by #70

Comments

@kdpuvvadi
Copy link

if commit.gpgsign is set to true, it's fine. At least a prompt for signing or as an argument such as aicommits -S.
@Nutlope
Copy link
Owner

Nutlope commented Feb 16, 2023

@privatenumber has a PR that should enable this but I'd love to learn more about the importance of signing commits. When would you need to do this?

@privatenumber privatenumber mentioned this issue Feb 17, 2023
Merged
@kdpuvvadi
Copy link
Author

When would you need to do this?

Most of the places i've worked at rejects unsigned commits

@privatenumber privatenumber mentioned this issue Feb 19, 2023
Closed
@Mahmoudgalalz
Copy link

#86 I did it here ?

@privatenumber
Copy link
Collaborator

privatenumber commented Feb 22, 2023 •
edited
Loading

Closed via #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: pass down argv to git commit Nutlope/aicommits
4 participants
@privatenumber @kdpuvvadi @Mahmoudgalalz @Nutlope