Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits and Periods #66

Closed
macjabeth opened this issue Feb 16, 2023 · 1 comment
Closed

Commits and Periods #66

macjabeth opened this issue Feb 16, 2023 · 1 comment

Comments

@macjabeth
Copy link

Awesome tool by the way!

I noticed that it automatically adds a period to the end of the commit message.

It is generally accepted that Git commit subject lines should not be ended with a period, just like email subject lines. This is particularly important to remember because of the 50 character limit, as every character counts.

I suggest a small change to the code that strips any period from the end should it exist.

@Nutlope
Copy link
Owner

Nutlope commented Feb 16, 2023

Agreed, this was just fixed in #59!

@Nutlope Nutlope closed this as completed Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants