Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove ending period #59

Merged
merged 3 commits into from
Feb 16, 2023
Merged

feat: remove ending period #59

merged 3 commits into from
Feb 16, 2023

Conversation

kxzk
Copy link
Contributor

@kxzk kxzk commented Feb 16, 2023

@kxzk
Copy link
Contributor Author

kxzk commented Feb 16, 2023

I saw your other message @privatenumber and played around with it online - same result. Seemingly, loves to slap that period on at the end. Makes me think the original idea may actually be more valid. The regex explicitly looks for it at the end of the message - so should be safe.

src/utils.ts Outdated Show resolved Hide resolved
Co-authored-by: hiroki osame <hiroki.osame@gmail.com>
@privatenumber privatenumber changed the title Remove ending period feat: remove ending period Feb 16, 2023
@privatenumber privatenumber merged commit 3f10195 into Nutlope:main Feb 16, 2023
@Nutlope Nutlope mentioned this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants