Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2767: Clean up systray menu #3973

Merged
merged 6 commits into from
Jun 6, 2023

Conversation

gitofanindya
Copy link
Collaborator

NXDRIVE-2767: Clean up systray menu

@CLAassistant
Copy link

CLAassistant commented May 24, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ gitofanindya
❌ anroy


anroy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +10.53 🎉

Comparison is base (2bdb332) 36.38% compared to head (0dc5b66) 46.91%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3973       +/-   ##
===========================================
+ Coverage   36.38%   46.91%   +10.53%     
===========================================
  Files          93       93               
  Lines       15640    15642        +2     
===========================================
+ Hits         5690     7339     +1649     
+ Misses       9950     8303     -1647     
Flag Coverage Δ
functional 37.64% <100.00%> (+1.26%) ⬆️
integration 1.98% <0.00%> (?)
unit 35.56% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nxdrive/options.py 99.51% <ø> (+19.41%) ⬆️
nxdrive/gui/view.py 36.23% <100.00%> (+36.23%) ⬆️

... and 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gitofanindya gitofanindya removed the request for review from poojadaine June 6, 2023 07:21
@gitofanindya gitofanindya merged commit 6f03912 into master Jun 6, 2023
@gitofanindya gitofanindya deleted the wip-NXDRIVE-2767-Clean-up-systray-menu branch June 6, 2023 07:26
gitofanindya added a commit that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants