Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE- : Fix alpha cleaup pipeline issue #4842

Closed

Conversation

swetayadav1
Copy link
Collaborator

No description provided.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @swetayadav1 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Comment on lines 8 to 10
pull_request:
paths:
- "tools/cleanup.txt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): Consider specifying types of pull request events.

It's good to specify paths for pull request triggers, but consider also specifying types of pull request activities (like 'opened', 'synchronize', etc.) to avoid unnecessary runs.

Suggested change
pull_request:
paths:
- "tools/cleanup.txt"
pull_request:
types: [opened, synchronize, reopened]
paths:
- "tools/cleanup.txt"

Comment on lines +21 to +22
print(f">>> Pwd: {os.getcwd()}")
print(f">>>>> list dir: {os.listdir(os.getcwd())}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (code_refinement): Debugging statements should be conditional or removed.

Printing the current working directory and its contents can be useful for debugging but might clutter the output in production. Consider making these conditional based on a debug flag or removing them after use.

Suggested change
print(f">>> Pwd: {os.getcwd()}")
print(f">>>>> list dir: {os.listdir(os.getcwd())}")
import os
def _load():
"""Get initial versions."""
if os.getenv('DEBUG', 'False').lower() in ['true', '1', 't']:
print(f">>> Pwd: {os.getcwd()}")
print(f">>>>> list dir: {os.listdir(os.getcwd())}")

@swetayadav1 swetayadav1 deleted the wip-NXDRIVE--Fix-alpha-cleanup-pipeline-issue branch May 10, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant