-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXDRIVE- : Fix alpha cleaup pipeline issue #4842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @swetayadav1 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
.github/workflows/alpha_cleanup.yml
Outdated
pull_request: | ||
paths: | ||
- "tools/cleanup.txt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): Consider specifying types of pull request events.
It's good to specify paths for pull request triggers, but consider also specifying types of pull request activities (like 'opened', 'synchronize', etc.) to avoid unnecessary runs.
pull_request: | |
paths: | |
- "tools/cleanup.txt" | |
pull_request: | |
types: [opened, synchronize, reopened] | |
paths: | |
- "tools/cleanup.txt" |
print(f">>> Pwd: {os.getcwd()}") | ||
print(f">>>>> list dir: {os.listdir(os.getcwd())}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (code_refinement): Debugging statements should be conditional or removed.
Printing the current working directory and its contents can be useful for debugging but might clutter the output in production. Consider making these conditional based on a debug flag or removing them after use.
print(f">>> Pwd: {os.getcwd()}") | |
print(f">>>>> list dir: {os.listdir(os.getcwd())}") | |
import os | |
def _load(): | |
"""Get initial versions.""" | |
if os.getenv('DEBUG', 'False').lower() in ['true', '1', 't']: | |
print(f">>> Pwd: {os.getcwd()}") | |
print(f">>>>> list dir: {os.listdir(os.getcwd())}") |
No description provided.