Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2917: Release Beta 5.4.1 #5012

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

mr-shekhar
Copy link
Collaborator

NXDRIVE-2917: Release Beta 5.4.1

@CLAassistant
Copy link

CLAassistant commented Jun 18, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mr-shekhar
❌ nuxeodrive
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

sourcery-ai bot commented Jun 18, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.36%. Comparing base (74fc14e) to head (7f4f432).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5012      +/-   ##
==========================================
+ Coverage   49.24%   49.36%   +0.12%     
==========================================
  Files          94       94              
  Lines       15699    15699              
==========================================
+ Hits         7731     7750      +19     
+ Misses       7968     7949      -19     
Flag Coverage Δ
functional 38.19% <100.00%> (+0.11%) ⬆️
integration 2.06% <ø> (ø)
unit 37.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-shekhar mr-shekhar added this to the 5.4.1 milestone Jun 18, 2024
@mr-shekhar mr-shekhar self-assigned this Jun 18, 2024
@mr-shekhar mr-shekhar merged commit 15aefe0 into master Jun 18, 2024
20 of 21 checks passed
@mr-shekhar mr-shekhar deleted the wip-NXDRIVE-2917-Release-5.4.1 branch June 18, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants