feat: improve token handling and validation #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize Token and Refresh Token instances inside schemes. Both classes now use scheme options instead of `$auth`. Also move token and refresh token prefixes to scheme `DEFAULTS`. Improve `check` method to also check tokens status, deprecating `_checkStatus`. Accept callbacks for token and refresh token expired status. Use types `AxiosRequestConfig` and `AxiosResponse` instead of `HTTPRequest` and `HTTPResponse`. RequestHandler class now use scheme options and methods instead of `$auth`.
|
Nice work |
|
Thanks 😄 |
# Conflicts: # src/inc/request-handler.ts
|
Have you defined the date of the V5 release ? |
|
Not yet. We want to make more improvements and refactors before release v5 :) |
DraftProducts
approved these changes
May 21, 2020
|
You should maybe add a todo list to the README of the project, in this way interested developers could make their contribution 😝 I would be interested myself 🙃 |
|
Actually we have a board, but we need to add some more things to it. |
pi0
reviewed
May 26, 2020
| constructor (auth: Auth) { | ||
| this.$auth = auth | ||
| constructor (scheme: Scheme, storage: Storage) { | ||
| this.scheme = scheme |
There was a problem hiding this comment.
However we call scheme instance strategy, i like your idea for simplification. Maybe can always call it scheme 👍
# Conflicts: # src/inc/request-handler.ts # src/schemes/local.ts # src/schemes/oauth2.ts # src/schemes/refresh.ts
Improve `check` to return object with token and refresh token expired status instead of accepting callbacks.
Object structure:
```
{
valid: boolean,
tokenExpired: boolean,
refreshTokenExpired: boolean,
isRefreshable: boolean
}
```
`valid` is the only required property.
# Conflicts: # src/schemes/refresh.ts
Alias `HTTPRequest` to `AxiosRequestConfig` and `HTTPResponse` to `AxiosResponse`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize Token and Refresh Token instances inside schemes. Both classes now use scheme options instead of
$auth. Also move token and refresh token prefixes to schemeDEFAULTS.Improve
checkmethod to also check tokens status, deprecating_checkStatus. Return object with token and refresh token expired status.Note:
validis the only required property.Alias
HTTPRequesttoAxiosRequestConfigandHTTPResponsetoAxiosResponse.RequestHandler class now use scheme options and methods instead of
$auth.