Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): new options #126

Merged
merged 3 commits into from
Jan 17, 2019
Merged

feat(icon): new options #126

merged 3 commits into from
Jan 17, 2019

Conversation

ricardogobbosouza
Copy link
Member

@ricardogobbosouza ricardogobbosouza commented Jan 17, 2019

@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #126 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #126   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines         2      2           
===================================
  Hits          2      2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e4e0f...d8c08d4. Read the comment docs.

@manniL manniL requested a review from pi0 January 17, 2019 13:28
@ricardogobbosouza ricardogobbosouza changed the title feat: new options feat(icon): new options Jan 17, 2019
@ricardogobbosouza
Copy link
Member Author

@pi0 and @manniL
Do you think it's worth changing the module to es6?

@pi0
Copy link
Member

pi0 commented Jan 17, 2019

Nice work @ricardogobbosouza.

Do you think it's worth changing the module to es6?

Nuxt loads modules through esm but as of introduction of nuxt-ts (typescript) this may be breaking change. So I suggest eventually upgrade all community modules at that point.

@pi0 pi0 merged commit 12e6576 into nuxt-community:dev Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NUXT, PWA] Icons target Directory Option
2 participants