Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump consola to 3.x to align with other nuxt 2 packages #224

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

rchl
Copy link
Collaborator

@rchl rchl commented Nov 16, 2023

Addressing the nuxt/nuxt#24343 issue which is about outdated consola being used in a couple of Nuxt 2 packages.

I've also had to update a bunch of dev dependencies for jest to be able to parse some newer syntax in consola 3.x.

@rchl
Copy link
Collaborator Author

rchl commented Nov 26, 2023

@wattanx could you do a sanity check here since you are working on the Nuxt 3 version of it?

Most of the changes are to get testing to work. The actual change that affects public is update to Consola 3.x and one line of change in the module.

Copy link
Collaborator

@wattanx wattanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rchl rchl merged commit c1aee33 into nuxt-modules:v1 Nov 27, 2023
2 checks passed
@rchl rchl deleted the v1 branch November 27, 2023 15:31
@deniscpaula
Copy link

deniscpaula commented Nov 28, 2023

@rchl
These "Major" dependencies updates causes breaking changes. The "consola" dependency was updated from ^2.15.3 to 3.2.3 which means it is not longer supported on node 12.

yes, I still have a project using node 12 🥲 , and it broke. But I resolved downgrade @nuxtjs/style-resources to 1.2.1

@rchl
Copy link
Collaborator Author

rchl commented Nov 28, 2023

We wouldn't be able to make a major release since the 2.x range is taken by Nuxt 3 version.

Also, if you are on Node 12 then I suppose you are also not on the latest Nuxt 2 version thus your setup isn't really supported anymore.

I appreciate you letting us know that this caused issue but I think it's the best we can do given the circumstances and probably the best course of action for your project is not to update anything in it anymore until you manage to switch to supported Nuxt and Node versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants