Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GitHub PR template #4

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

shinGangan
Copy link
Contributor

🔗 Linked issue

📚 Description

The number of repositories managed by Nuxt organizations is increasing day by day, and I think the cost of managing the repositories is on the rise.
I often see PRs that add GitHub PR templates to each repository for repository operation, but I think this can be solved by placing them in nuxt/.github.

The behavior that occurs in each repository is as follows.

.github/pull_request_template.md has been placed

The pull_request_template.md set in each repository will take priority.

If a repository has any files in its own .github/ISSUE_TEMPLATE folder, including issue templates or a config.yml file, none of the contents of the default .github/ISSUE_TEMPLATE folder will be used.

.github/pull_request_template.md has not been placed

The pull_request_template.md in this repository will be used when creating a PR.

✍️ Note

  • Only the GitHub PR template is added in this PR. The GitHub Issue template will be added in a separate PR.
  • If there are no issues with this PR, we will take the same steps in the Nuxt modules organization.

@shinGangan
Copy link
Contributor Author

My opinion...

I often use the previous ❓ Type of change item.
So I think it's fine for it to exist.

@shinGangan
Copy link
Contributor Author

shinGangan commented Jul 23, 2024

Hi @danielroe , I would appreciate it if you could leave a comment when you have time. 🙏

Thank you for always reviewing.

@danielroe
Copy link
Member

I would be happy to add back the 'type of change' section too.

@shinGangan
Copy link
Contributor Author

I would be happy to add back the 'type of change' section too.

OK! Added in this commit: 2f0d44b

@danielroe danielroe merged commit cf5d79a into nuxt:main Jul 23, 2024
@shinGangan shinGangan deleted the chore/add-pr-template branch July 23, 2024 18:32
@shinGangan
Copy link
Contributor Author

Thanks for merged 💚

@danielroe
Copy link
Member

Thank you for the initiative! 🙏

@shinGangan shinGangan mentioned this pull request Jul 23, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants