-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom editor API #312
Conversation
Custom editor exampleTo test this with a custom editor (created by me :D ) follow this steps:
content: {
editor: '../../../node_modules/nuxt-content-editor/editor.vue',
}, We have to use this relative path as editor.vue has to be comp-/transpiled |
@benjamincanac This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this need tests as well as using alias resolution + suggested changes
Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
Todos
Alias resolutionAs I understand you mean pathes like Pathes like 'myNPMpackage/editor.js' are working too. TestingWhat has to be tested?
|
@atinux |
@atinux added some tests... |
@benjamincanac @atinux is there any progress on the review? |
Hi @mathe42 We were on holidays this week. |
This PR is a rebased version of #308
Types of changes
Description
With
you can define your own component for editing.
Your component should implement the following:
endEdit
Resolves #303
Example
https://github.com/mathe42/content-editor
Checklist:
Tests
I think existing tests should be enough. I didn't touch the tests and they didn't break.