Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement csv parser with unist/mircomark stack #1468

Merged
merged 6 commits into from
Aug 25, 2022
Merged

Conversation

farnabaz
Copy link
Member

πŸ”— Linked issue

resolves #1440

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR attempts to replace CSV parser package with a custom parser based on unist/remark stack.
This approach will be compatible with all deploy targets and also, as of my tests the performance is better than external package

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 22, 2022

βœ… Deploy Preview for nuxt-content ready!

Name Link
πŸ”¨ Latest commit 8a53baf
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/6304dd8e291b4f0009d216d1
😎 Deploy Preview https://deploy-preview-1468--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@farnabaz farnabaz marked this pull request as draft August 22, 2022 15:41
@atinux atinux changed the title refactor: implement csv parser with unist/mircomark stack stack refactor: implement csv parser with unist/mircomark stack Aug 22, 2022
@farnabaz farnabaz marked this pull request as ready for review August 23, 2022 11:42
@farnabaz farnabaz requested a review from atinux August 24, 2022 12:41
@atinux atinux changed the title refactor: implement csv parser with unist/mircomark stack feat: implement csv parser with unist/mircomark stack Aug 25, 2022
@atinux atinux merged commit ce5397d into main Aug 25, 2022
@atinux atinux deleted the refactor/csv branch August 25, 2022 14:01
@atinux
Copy link
Member

atinux commented Aug 25, 2022

Amazing work 🀯

@farnabaz farnabaz mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace csvtojson with modern package
2 participants