fix: allow empty string in $contains
#2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt-content canceled.Built without sensitive environment variables
|
Barbapapazes
changed the title
contains$contains
farnabaz
reviewed
Jul 18, 2023
|
Do you mind adding some tests for it in https://github.com/nuxt/content/blob/main/test/features/query/match.test.ts |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
fix #2158
❓ Type of change
📚 Description
Hello,
I'm not sure if the fix must be in the
ensureArrayfunction or in the$containsfunction (src/runtime/query/match).📝 Checklist