Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 244 pass globalName to plugin client to make sure it works #251

Merged
merged 2 commits into from
Jul 20, 2020
Merged

fix: 244 pass globalName to plugin client to make sure it works #251

merged 2 commits into from
Jul 20, 2020

Conversation

flozero
Copy link
Contributor

@flozero flozero commented Jul 11, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

fix #244. Adding globalName as options into plugin.client.js

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2020

Codecov Report

Merging #251 into dev will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #251      +/-   ##
==========================================
- Coverage   89.56%   89.46%   -0.10%     
==========================================
  Files          15       15              
  Lines         527      541      +14     
  Branches      107      111       +4     
==========================================
+ Hits          472      484      +12     
- Misses         48       50       +2     
  Partials        7        7              
Impacted Files Coverage Δ
lib/index.js 77.01% <100.00%> (+0.54%) ⬆️
lib/middleware.js 82.43% <0.00%> (-2.08%) ⬇️
lib/query-builder.js 98.92% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a4b884...67d39fb. Read the comment docs.

@atinux
Copy link
Member

atinux commented Jul 15, 2020

Updated to use this.options.globals.readyCallback :)

@atinux atinux self-requested a review July 15, 2020 17:26
@benjamincanac benjamincanac merged commit 3a6a022 into nuxt:dev Jul 20, 2020
benjamincanac pushed a commit that referenced this pull request Jul 20, 2020
* fix: 244 pass globalName to plugin client to make sure it works

* fix: use globals.readyCallback instead

Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
benjamincanac pushed a commit that referenced this pull request Jul 27, 2020
* fix: 244 pass globalName to plugin client to make sure it works

* fix: use globals.readyCallback instead

Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect globalName of nuxt.config.js
4 participants