Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: order of query execution #267

Closed
wants to merge 1 commit into from
Closed

fix: order of query execution #267

wants to merge 1 commit into from

Conversation

dtmzr
Copy link

@dtmzr dtmzr commented Jul 15, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Within #95 we recognized some odd behavior for the search results in the provided example.
In this issue, a possible solution was provided - it seemed like the order the in which the query is executed had some unpredicted impact on the results.
With this fix, the provided example works as expected.
The examples within this module work as expected too.

Feedback is very welcome.
If you're using advanced queries with this module, double-checking if this fix causes issues would be awesome!

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2020

Codecov Report

❗ No coverage uploaded for pull request base (dev@65d05d0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev     #267   +/-   ##
======================================
  Coverage       ?   89.46%           
======================================
  Files          ?       15           
  Lines          ?      541           
  Branches       ?      111           
======================================
  Hits           ?      484           
  Misses         ?       50           
  Partials       ?        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65d05d0...ed70856. Read the comment docs.

@benjamincanac
Copy link
Member

Hey @dtmzr,

Are you sure this is necessary? Since #238 has been merged, skip and limit should apply at the very end already.

This is not yet released but available on the dev branch, you can try it:

{
  "dependencies": {
    "@nuxt/content": "nuxt/content#dev"
  }
}

@dtmzr
Copy link
Author

dtmzr commented Jul 17, 2020

Hey @benjamincanac,

thanks for the hint, I wasn't aware of this PR.
I'll do a double-check a little later and provide feedback. 🙏

@dtmzr
Copy link
Author

dtmzr commented Jul 17, 2020

@benjamincanac yep you were totally right, the with the current dev version this issue is fixed 🚀
I'll close this PR and add this information to the issue.

Thanks for your work 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants