Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prerender): ensure / exists inside prerender rotues #2673

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

farnabaz
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

cloudflare-workers-and-pages bot commented Jun 20, 2024

Deploying nuxt-content with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: 48d10a3
Status:Β βœ…Β  Deploy successful!
Preview URL: https://b9c3b835.nuxt-content-1il.pages.dev
Branch Preview URL: https://prerender-home.nuxt-content-1il.pages.dev

View logs

@farnabaz farnabaz merged commit fa124d3 into main Jun 20, 2024
3 checks passed
@farnabaz farnabaz deleted the prerender-home branch June 20, 2024 14:15
@stefanprobst
Copy link
Contributor

@farnabaz i think this breaks nuxt/i18n, which intentionally removes "/" from prerendering so redirecting to "/en" still works. see nuxt-modules/i18n#2894

@ptdev
Copy link

ptdev commented Jun 25, 2024

@farnabaz i think this breaks nuxt/i18n, which intentionally removes "/" from prerendering

Confirming that it did indeed break i18n. See #2678

@ydnar
Copy link

ydnar commented Jun 28, 2024

This PR, with its unilateral addition of / to the prerender list, broke production for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants