Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Included types folder in files #525

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Conversation

dipsaus9
Copy link
Contributor

@dipsaus9 dipsaus9 commented Oct 1, 2020

Include all typescript files on build. This will solve the problem that parsers are not included in the build.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

In #444 I created a PR for extra types. By mistake I didn't add these files to the package.json for build process. This means in test environment it works but after a build the parser types are not included. I believe including all *.d.ts files in the package.json will resolve this problem.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@dipsaus9 dipsaus9 changed the title Included types folder in files fix: Included types folder in files Oct 1, 2020
Copy link
Contributor

@mathe42 mathe42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@atinux atinux self-requested a review October 1, 2020 09:16
@benjamincanac benjamincanac merged commit 0c6df8f into nuxt:dev Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants