Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #653 - remark-gfm dependency added to manage markdown tables #654

Merged
merged 4 commits into from
Nov 24, 2020
Merged

fix: #653 - remark-gfm dependency added to manage markdown tables #654

merged 4 commits into from
Nov 24, 2020

Conversation

paolodenti
Copy link
Contributor

@paolodenti paolodenti commented Nov 21, 2020

Fix for issue 653

Markdown tables not rendered in 9.0.0

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

new dependency added: remark-gfm
use of new dependency added:

const gfm = require('remark-gfm')

let stream = unified().use(parse).use(gfm)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@paolodenti paolodenti changed the title remark-gfm dependency added to manage markdown tables fix: #653 - remark-gfm dependency added to manage markdown tables Nov 21, 2020
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I wasn't aware that remark-parse was not handling gfm anymore.

package.json Outdated Show resolved Hide resolved
packages/content/parsers/markdown/index.js Outdated Show resolved Hide resolved
@paolodenti
Copy link
Contributor Author

@benjamincanac
the tests are failing while "fetching packets", network issues. I do not know how they can be triggered again.

@benjamincanac benjamincanac linked an issue Nov 24, 2020 that may be closed by this pull request
@benjamincanac benjamincanac merged commit 5a5c6ac into nuxt:dev Nov 24, 2020
@benjamincanac
Copy link
Member

@paolodenti I relaunched the tests, all good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs Theme - MD tables not working anymore in 0.8.0
2 participants