feat(template): remove dotenv module #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we know why? |
|
@web2033 this is related to the fact that Nuxt v2.13 will directly support Actually |
|
Why we removed the @nuxtjs/dotenv module |
|
@Atinux I think you meant this -> https://nuxtjs.org/blog/moving-from-nuxtjs-dotenv-to-runtime-config |
Atinux
pushed a commit
that referenced
this pull request
Jun 19, 2020
Atinux
added a commit
that referenced
this pull request
Jun 22, 2020
* feat: prepare for Nuxt 2.13 * fix(jest): downgrate vue-jest to v3 pending by vuejs/vue-jest#241 * chore(deps): update all non-major dependencies (#509) * fix(prettier): add stylelint-config-prettier * chore(deps): update jest packages (major) (#513) * chore: add npm registry config * chore(deps): update all non-major dependencies * chore(deps): update devdependency @nuxt/typescript-build to v1 * fix(ava): expect vm truthy as vue instance assertion * chore(deps): update all non-major dependencies * chore(deps): update all non-major dependencies * feat(template): remove dotenv module (#544) * chore: optimize svg & animation (#547) * feat: add content module (#540) * chore(deps): update all non-major dependencies * chore(deps): lock file maintenance (#541) * v3.0.0 * chore: update snapshots * chore: update prompts and add TS runtime by default * chore: fix lint issue Co-authored-by: Clark Du <clark.duxin@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com> Co-authored-by: Benjamin Canac <canacb1@gmail.com> Co-authored-by: Pooya Parsa <pyapar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @Atinux has mentioned in discord, we should remove dotenv module from create-nuxt-app now.