-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enabling timeline breaks makro imports #507
Comments
Got weird errors with undefined composables in our project. Disabled timeline - and all of them got fixed. |
I ran into this in my project. Checked the repro above with the latest devtools and its erroring. This still seems to be an issue. |
The error still exists for me with version 1.0.8. |
Could you share the link? 🙏 |
its your repro in the initial issue |
Yesyes, but my reproduction is from 2,5 months ago. You said that with a newer devtools version the issue reappeared, so it would be interesting to have a link to the updated reproduction you mentioned. |
Sorry for the confusion. Your repro package.json has |
Oh, I didn't know that With devtools v1.0.8 you have: as intended. Updated fork: https://stackblitz.com/edit/github-zpd6br-2ppzmo?file=package.json |
🐛 The bug
The
nuxt:pages-macros-transform
removes the whole lineimport { abortNavigation as _$__abortNavigation } from '#app';;import { __nuxtTimelineWrap } from "/home/projects/github-zpd6br/node_modules/@nuxt/devtools/dist/runtime/function-metrics-helpers";const abortNavigation = __nuxtTimelineWrap("abortNavigation", _$__abortNavigation);
.Letting
abortNavigation
be undefined.🛠️ To reproduce
https://stackblitz.com/edit/github-zpd6br?file=pages%2Findex.vue
🌈 Expected behavior
const abortNavigation = __nuxtTimelineWrap("abortNavigation", _$__abortNavigation);
is kept.ℹ️ Additional context
I think this error must be fixed in
nuxt
, notdevtools
. (cc @danielroe)The text was updated successfully, but these errors were encountered: