Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can't sort when search some keyword in module install list #669

Closed
enpitsuLin opened this issue May 28, 2024 · 0 comments · Fixed by #670
Closed

fix: can't sort when search some keyword in module install list #669

enpitsuLin opened this issue May 28, 2024 · 0 comments · Fixed by #670
Labels
bug Something isn't working

Comments

@enpitsuLin
Copy link
Contributor

enpitsuLin commented May 28, 2024

🐛 The bug

Navigate to the modules tab and click Install New Module

image

if there are no search key word, sort option will work properly, but input something will break its functional, can't show sorted items as it should be

🛠️ To reproduce

https://stackblitz.com/github/nuxt/starter/tree/v3

🌈 Expected behavior

if user input some keyword then change sort key or toggle order, the module list should show sorted list of search result rather just search result

ℹ️ Additional context

When I want add some module and input keyword like 'auth' and I got Hebilicious/authjs-nuxt on the top of list instead sidebase, but the latter has more installed and stars than former, it confuse me.

and also found change sort option and click toggle order button there are nothing happen, it's broken

I think fundamental problem is fuse.js after checking code of this part, I will open a PR later

@enpitsuLin enpitsuLin added the bug Something isn't working label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant