-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: disable multiword-rule #190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Could we implement via overrides instead (e.g. for **/pages/**
), as you've linked to this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I think is better than just disabling it. as @danielroe said.
rules: {
'vue/multi-word-component-names': 'off',
},
overrides: [
{
files: ['components/*.{js,ts,vue}'],
rules: {
'vue/multi-word-component-names': 'error',
}
}
]
I'd probably do it the other way around, given that components could live in many folders but page components usually only in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay yeah that's smart..
@manniL can you check why test is failing tho ? |
when this feature will be released? installing latest version: |
It doesn't handle the case when page components are in |
@rchl I suppose |
In my case, I use an 'src' folder for all my components, assets, pages, etc. The lint kicks-in in this case. |
Not ideal for page components :(
Resolves #192
Better would be disabling it for the pages folder only I'd say 😋