This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(nuxt3)!: enable using <NuxtLayout>
without pages integration
#3610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
βοΈ Deploy Preview for nuxt3-docs canceled. π¨ Explore the source changes: 549ffef π Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/622f1b604d3ea40008ea5317 |
pi0
reviewed
Mar 11, 2022
```vue | ||
```vue{}[app.vue] | ||
<template> | ||
<NuxtLayout :name="$route.path === '/' ? 'custom' : false"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe split into simple layout usage and a dynamic example for more advanced cases using a computed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll simplify this. Maybe we can keep the example at the end of the file for the computed.
danielroe
changed the title
feat(nuxt3): enable using
feat(nuxt3)!: enable using Mar 12, 2022
<NuxtLayout>
without pages integration<NuxtLayout>
without pages integration
pi0
reviewed
Mar 14, 2022
pi0
reviewed
Mar 14, 2022
pi0
approved these changes
Mar 14, 2022
pi0
approved these changes
Mar 14, 2022
18 tasks
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves nuxt/nuxt#12829
β Type of change
π Description
This PR extracts the Nuxt layouts integration out of the pages module, meaning
<NuxtLayout>
can be used anywhere in a Nuxt app even if the~/pages
integration isn't.It also adds support for
extends
with layouts.BREAKING CHANGE:
pages:layouts:extend
hookPossible improvements
<NuxtLayout>
- this would require a new utility interface exported from #app that we could hook into here and inPageMeta
π Migration
pages:layouts:extend
hook, then you can switch to usingapp:resolve
, where you will be able to accessapp.layouts
.π Checklist