Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

docs: add documentation for titleTemplate #5093

Merged
merged 4 commits into from
Jun 3, 2022
Merged

docs: add documentation for titleTemplate #5093

merged 4 commits into from
Jun 3, 2022

Conversation

heychazza
Copy link
Contributor

πŸ”— Linked issue

nuxt/nuxt#13981 (And #5057 for PR)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This change adds more clarity to the titleTemplate option, as currently in Nuxt 3 this doesn't work as intended. This resolves nuxt/nuxt#13981. This is a re-added PR to #5057, accidentally deleted the repo when adding multiple PRs to Nuxt.

Some changes were resolved by @manniL, @danielroe and @DamianGlowala.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented May 21, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 4626e89
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/629a1e85a4a52c0008d5818d
😎 Deploy Preview https://deploy-preview-5093--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroe danielroe self-requested a review May 21, 2022 10:08
@atinux
Copy link
Member

atinux commented May 23, 2022

Thanks @heychazza

I would suggest to document it to be used in app.vue instead of creating a plugin for it. Otherwise changes look good to me!

@danielroe
Copy link
Member

Yes, please see my suggested changes on the previous PR.

@heychazza
Copy link
Contributor Author

Thanks @heychazza

I would suggest to document it to be used in app.vue instead of creating a plugin for it. Otherwise changes look good to me!

Thank you lots! Daniel did mention this but I completely overlooked it.

Will add those changes tomorrow once I'm at the computer.

@pi0 pi0 merged commit e6b48c2 into nuxt:main Jun 3, 2022
@heychazza heychazza deleted the update-documentation-for-titletemplate branch June 3, 2022 15:50
@pi0 pi0 mentioned this pull request Jun 10, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set titleTemplate as function
4 participants