Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

docs: fix nuxt app guide linking to a 404 page #5122

Merged
merged 2 commits into from
May 24, 2022
Merged

docs: fix nuxt app guide linking to a 404 page #5122

merged 2 commits into from
May 24, 2022

Conversation

heychazza
Copy link
Contributor

@heychazza heychazza commented May 24, 2022

πŸ”— Linked issue

N/A

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Updates the nuxt app docs as the link went to a 404, on closer look it seems this isn't being caught by

/docs/directory-structure/* /guide/directory-structure/:splat 302!

Update: Seems navigating through the app itself gives a 404, but going directly to the link redirects me.

Reproduction

  1. Go to https://v3.nuxtjs.org/guide/going-further/nuxt-app/
  2. Click Read more about plugins.
  3. It 404's.
  4. If you refresh the page at the 404, it'll redirect you.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented May 24, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit f78a2b2
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/628ca985dafdf2000851bd7f
😎 Deploy Preview https://deploy-preview-5122--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@heychazza
Copy link
Contributor Author

On further inspection, it seems like Netlifys redirection rules don't apply within the docs itself. I'm unsure if the docs are an SPA or something alike, where Netlify would never see the page load (after first loading).

See:
CleanShot 2022-05-24 at 10 53 15

@pi0
Copy link
Member

pi0 commented May 24, 2022

On further inspection, it seems like Netlifys redirection rules don't apply within the docs itself. I'm unsure if the docs are an SPA or something alike, where Netlify would never see the page load (after first loading).

We always had this issue but will hopefully be solved once we had routes rules that can generate universal redirection rules (both netlify-native and app universal)

@pi0
Copy link
Member

pi0 commented May 24, 2022

Thanks!

@pi0 pi0 merged commit 32cb06b into nuxt:main May 24, 2022
@heychazza
Copy link
Contributor Author

On further inspection, it seems like Netlifys redirection rules don't apply within the docs itself. I'm unsure if the docs are an SPA or something alike, where Netlify would never see the page load (after first loading).

We always had this issue but will hopefully be solved once we had routes rules that can generate universal redirection rules (both netlify-native and app universal)

Ah I see! That makes sense, the fun of super strange bugs haha

@heychazza heychazza deleted the update-nuxt-app-documentation branch May 24, 2022 14:16
@pi0 pi0 mentioned this pull request Jun 10, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants