Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

build(vite): add missing pkg-types dependency #6128

Merged
merged 1 commit into from
Jul 25, 2022
Merged

build(vite): add missing pkg-types dependency #6128

merged 1 commit into from
Jul 25, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jul 25, 2022

πŸ”— Linked issue

resolves nuxt/nuxt#14416

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Likely an upstream issue to fix in unbuild also (can track in unjs/unbuild#97 - cc: @pi0). But we should not be inlining pkg-types in any case (introduced in #6069).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Jul 25, 2022
@danielroe danielroe requested a review from pi0 July 25, 2022 14:27
@danielroe danielroe self-assigned this Jul 25, 2022
@netlify
Copy link

netlify bot commented Jul 25, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 157f39d
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62dea84f0ea0bf000977cb3d

@pi0 pi0 changed the title build: add pkg-types dep (prevents inlining) build(vite): add missing pkg-types dependency Jul 25, 2022
@pi0 pi0 merged commit 133723f into main Jul 25, 2022
@pi0 pi0 deleted the build/add-dep branch July 25, 2022 15:18
@pi0 pi0 mentioned this pull request Aug 5, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken @nuxt/vite-builder
2 participants