This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): render head scripts that use body: true
#6293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves naming difference with NuxtMeta and @vueuse/head causing the scripts not to be rendered. This allows applies to `link`.
✅ Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
7 tasks
pi0
approved these changes
Aug 2, 2022
pi0
changed the title
body: truebody: true
Atinux
approved these changes
Aug 2, 2022
DamianGlowala
suggested changes
Aug 2, 2022
Co-authored-by: Damian Głowala <48835293+DamianGlowala@users.noreply.github.com>
Co-authored-by: Damian Głowala <48835293+DamianGlowala@users.noreply.github.com>
Co-authored-by: Damian Głowala <48835293+DamianGlowala@users.noreply.github.com>
Co-authored-by: Damian Głowala <48835293+DamianGlowala@users.noreply.github.com>
|
Thanks for docs improvements @DamianGlowala! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
@vueuse/head PR: vueuse/head#67
issues: nuxt/nuxt#13069, nuxt/nuxt#13991, nuxt/nuxt#13345
❓ Type of change
📚 Description
With nuxt using the latest version of @vueuse/head, it already has support for appending script and links to the end of the body tag with the
body: trueoption.However due to a mismatch with property names of NuxtMeta and @vueuse/head nothing is rendered, this fixes that and adds some small doc and tests around the feature
Note: This does not work in components, this will need to be looked at in a separate PR as there is some extra complexity involved
📝 Checklist