This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(vite): don't fail builds for virtual modules that don't support inlining #7440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves nuxt/nuxt#14855
β Type of change
π Description
Virtual CSS files that want Nuxt inline styles need to respond to the resolved ID with the correct query flags (
?inline&used
). I've updated three key virtual CSS modules (see linked issue). But we shouldn't fail builds if user is using some other virtual CSS module; this PR simply makes sure we skip those virtual modules. Any CSS they inject will not be inlined.)We could also display a warning message so users at least know this is happening and know where to raise an issue. wdyt @pi0?
π Checklist