Skip to content

Commit 2b4bac9

Browse files
committed
test: close out playwright page after each test
1 parent b3bde17 commit 2b4bac9

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

test/e2e/no-ssr.test.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@ describe('browser (ssr: false)', () => {
2424

2525
const requests: string[] = []
2626
const page = await createPage()
27-
page.route('**', (route) => {
27+
await page.route('**', (route) => {
2828
requests.push(route.request().url())
2929
return route.continue()
3030
})
31-
page.goto(url(providerPath))
31+
await page.goto(url(providerPath))
3232

3333
await page.waitForSelector('img')
3434
const images = await page.getByRole('img').all()
@@ -39,6 +39,8 @@ describe('browser (ssr: false)', () => {
3939
expect(sources).toMatchSnapshot()
4040

4141
expect(requests.map(r => r.replace(url('/'), '/')).filter(r => r !== providerPath && !r.match(/\.(js|css)/))).toMatchSnapshot()
42+
43+
await page.close()
4244
})
4345
}
4446

@@ -52,5 +54,7 @@ describe('browser (ssr: false)', () => {
5254

5355
expect(logs.filter(log => log === 'Image was loaded').length).toBe(4)
5456
expect(logs.filter(log => log === 'Error loading image').length).toBe(2)
57+
58+
await page.close()
5559
})
5660
})

test/e2e/ssr.test.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@ describe('browser (ssr: true)', () => {
2424
const page = await createPage()
2525

2626
const requests: string[] = []
27-
page.route('**', (route) => {
27+
await page.route('**', (route) => {
2828
requests.push(route.request().url())
2929
return route.continue()
3030
})
3131

32-
page.goto(url(providerPath))
32+
await page.goto(url(providerPath))
3333

3434
await page.waitForSelector('img')
3535
const images = await page.getByRole('img').all()
@@ -40,6 +40,8 @@ describe('browser (ssr: true)', () => {
4040
expect(sources).toMatchSnapshot()
4141

4242
expect(requests.map(r => r.replace(url('/'), '/')).filter(r => r !== providerPath && !r.match(/\.(js|css)/))).toMatchSnapshot()
43+
44+
await page.close()
4345
})
4446
}
4547

@@ -49,12 +51,14 @@ describe('browser (ssr: true)', () => {
4951

5052
page.on('console', (msg) => { logs.push(msg.text()) })
5153

52-
page.goto(url('/events'))
54+
await page.goto(url('/events'))
5355

5456
await page.waitForLoadState('networkidle')
5557

5658
expect(logs.filter(log => log === 'Image was loaded').length).toBe(4)
5759
expect(logs.filter(log => log === 'Error loading image').length).toBe(2)
60+
61+
await page.close()
5862
})
5963

6064
it('works with runtime ipx', async () => {

0 commit comments

Comments
 (0)