Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPX runtime not work with external domains #324

Closed
oritwoen opened this issue Jun 16, 2021 · 1 comment · Fixed by #333
Closed

IPX runtime not work with external domains #324

oritwoen opened this issue Jun 16, 2021 · 1 comment · Fixed by #333
Assignees
@danielroe
Labels
bug Something isn't working

Comments

@oritwoen
Copy link

Hi, I was strictly following the instructions found at: https://image.nuxtjs.org/providers/ipx

I checked in many ways, but none of IPX with external domains works.

I created a reproduction: https://codesandbox.io/s/hardcore-euclid-w94ox?file=/pages/index.vue
@julien1619
Copy link

Hello! I can confirm this problem. I tried to investigate a little bit and _options.domains is always undefined here https://github.com/nuxt/image/blob/main/src/runtime/image.ts#L112

@pi0 pi0 added the bug Something isn't working label Jun 21, 2021
@danielroe danielroe self-assigned this Jun 23, 2021
danielroe added a commit that referenced this issue Jun 23, 2021
@danielroe
fix: default ipx, static and vercel domains options to module options
f94fbbe 
closes #324
@danielroe danielroe mentioned this issue Jun 23, 2021
Merged
@pi0 pi0 closed this as completed in #333 Jun 23, 2021
pi0 pushed a commit that referenced this issue Jun 23, 2021
@danielroe
fix: pass domains to runtime options (#333)
33ada92 
closes #324
procrates pushed a commit to procrates/nuxt-image that referenced this issue Feb 21, 2023
@danielroe
fix: pass domains to runtime options (nuxt#333)
becd0fa 
closes nuxt#324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielroe danielroe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pass domains to runtime options nuxt/image
4 participants
@julien1619 @pi0 @oritwoen @danielroe