-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass domains
to runtime options
#333
Conversation
Codecov Report
@@ Coverage Diff @@
## main #333 +/- ##
===========================================
- Coverage 59.50% 14.25% -45.25%
===========================================
Files 26 24 -2
Lines 600 533 -67
Branches 150 136 -14
===========================================
- Hits 357 76 -281
- Misses 243 457 +214
Continue to review full report at Codecov.
|
Multi-provider purpose is to allow transparently switching between them (they can yet normalize to what they expect like trimming to hostname only) For domain is there any special reason to make it vendor-specific? Why is important? By ensuring there is one source of trust of allowed domains, we can also warn users in runtime (without provider level check) domain is not included or automatically externalize. |
domains
to runtime options
This no longer treats
static
as unique and moves domains to the global context.closes #324