Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error readability #79

Merged
merged 6 commits into from
Nov 13, 2020
Merged

fix: improve error readability #79

merged 6 commits into from
Nov 13, 2020

Conversation

farnabaz
Copy link
Member

close #77

@codecov-io
Copy link

codecov-io commented Nov 12, 2020

Codecov Report

Merging #79 (72cf3ee) into master (d1c73c9) will decrease coverage by 1.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   73.30%   72.12%   -1.19%     
==========================================
  Files          21       21              
  Lines         547      556       +9     
  Branches      128      130       +2     
==========================================
  Hits          401      401              
- Misses        145      155      +10     
+ Partials        1        0       -1     
Impacted Files Coverage Δ
src/runtime/meta.ts 0.00% <0.00%> (ø)
src/runtime/nuxt-image.ts 76.47% <0.00%> (-2.32%) ⬇️
src/index.ts 95.00% <0.00%> (ø)
src/providers/ipx/index.ts 100.00% <0.00%> (ø)
src/runtime/nuxt-picture.ts 81.25% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c73c9...72cf3ee. Read the comment docs.

@farnabaz farnabaz merged commit 763f215 into master Nov 13, 2020
@farnabaz farnabaz deleted the placeholder-error branch November 13, 2020 14:11
@farnabaz
Copy link
Member Author

Thank you @pi0 ❤️

procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Co-authored-by: Pooya Parsa <pyapar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error not readable when url is not valid - Attempt to write outside buffer bounds
3 participants