-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow setting global quality
defaults in config
#884
Conversation
✅ Live Preview ready!
|
👷 Deploy request for nuxt-image pending review.Visit the deploys page to approve it
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #884 +/- ##
==========================================
+ Coverage 89.71% 89.76% +0.05%
==========================================
Files 43 43
Lines 2770 2775 +5
Branches 311 312 +1
==========================================
+ Hits 2485 2491 +6
+ Misses 284 283 -1
Partials 1 1
☔ View full report in Codecov by Sentry. |
You are a star - thank you ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
The solution should also apply quality
at module config level to <nuxt-picture>
, right?
Could you please also add tests to test/unit/picture.test.ts
?
Thank you very much 🙏 I only added one test, should I add all the tests that I did for |
Fair enough, I think this is good to go! 💪 |
Hi there 👋
This PR allows setting the quality of the generated images in the module configuration.
Thank you very much for the amazing work 🚀