Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting global quality defaults in config #884

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

Tragio
Copy link
Contributor

@Tragio Tragio commented Jun 21, 2023

Hi there 👋

This PR allows setting the quality of the generated images in the module configuration.

Thank you very much for the amazing work 🚀

@nuxt-studio
Copy link

nuxt-studio bot commented Jun 21, 2023

Live Preview ready!

Name Edit Preview Latest Commit
Image Edit on Studio ↗︎ View Live Preview a0e9837

@netlify
Copy link

netlify bot commented Jun 21, 2023

👷 Deploy request for nuxt-image pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a0e9837

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (919d9fd) 89.71% compared to head (a0e9837) 89.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #884      +/-   ##
==========================================
+ Coverage   89.71%   89.76%   +0.05%     
==========================================
  Files          43       43              
  Lines        2770     2775       +5     
  Branches      311      312       +1     
==========================================
+ Hits         2485     2491       +6     
+ Misses        284      283       -1     
  Partials        1        1              
Impacted Files Coverage Δ
src/module.ts 91.61% <100.00%> (+0.70%) ⬆️
src/runtime/components/_base.ts 100.00% <100.00%> (ø)
src/types/image.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danielroe
Copy link
Member

You are a star - thank you ❤️

Copy link
Collaborator

@hartmut-co-uk hartmut-co-uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
The solution should also apply quality at module config level to <nuxt-picture>, right?

Could you please also add tests to test/unit/picture.test.ts?

@Tragio
Copy link
Contributor Author

Tragio commented Jun 21, 2023

Great! The solution should also apply quality at module config level to <nuxt-picture>, right?

Could you please also add tests to test/unit/picture.test.ts?

Thank you very much 🙏 I only added one test, should I add all the tests that I did for nuxt-img? Just don't want to be redundant, since all is being passed to nuxt-picture. If you want I can do it without any problem 😄

@hartmut-co-uk
Copy link
Collaborator

Fair enough, I think this is good to go! 💪

@danielroe danielroe merged commit f5e2aa2 into nuxt:main Jun 21, 2023
@Tragio Tragio deleted the feat/global-quality branch June 21, 2023 21:16
@danielroe danielroe mentioned this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants