Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: migrate to ipx v2 #988

Merged
merged 16 commits into from
Sep 28, 2023
Merged

feat!: migrate to ipx v2 #988

merged 16 commits into from
Sep 28, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 14, 2023

Migrate to IPX v2 for better future compatibility 🚀

v2 roadmap: unjs/ipx#171

  • Update types
  • Working dev handler
  • Working runtime -- logic is now unified with runtime
  • Integrate with storage layer for cache support (deferred)

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 14, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4a69915
Status: ✅  Deploy successful!
Preview URL: https://2d35c98a.nuxt-image.pages.dev
Branch Preview URL: https://feat-ipx-v2.nuxt-image.pages.dev

View logs

@pi0 pi0 requested a review from danielroe September 21, 2023 21:31
@pi0 pi0 marked this pull request as ready for review September 21, 2023 21:31
src/types/module.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
sorry, this is a ridiculous commit, but I couldn't face it not being alphabetised
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (92e1787) 89.44% compared to head (4a69915) 89.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #988      +/-   ##
==========================================
+ Coverage   89.44%   89.91%   +0.46%     
==========================================
  Files          44       44              
  Lines        2918     2905      -13     
  Branches      328      328              
==========================================
+ Hits         2610     2612       +2     
+ Misses        307      292      -15     
  Partials        1        1              
Files Coverage Δ
src/types/module.ts 100.00% <100.00%> (ø)
src/ipx.ts 95.65% <97.56%> (+18.27%) ⬆️
src/runtime/utils/index.ts 76.29% <0.00%> (-0.57%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielroe
Copy link
Member

danielroe commented Sep 23, 2023

having talked to @pi0, this needs to be investigated #988 (comment).

marking as draft until we look into it further.

@danielroe danielroe marked this pull request as draft September 23, 2023 11:47
@pi0 pi0 marked this pull request as ready for review September 27, 2023 23:18
@danielroe danielroe merged commit 2387d47 into main Sep 28, 2023
3 checks passed
@danielroe danielroe deleted the feat/ipx-v2 branch September 28, 2023 08:25
riddla pushed a commit to tricks-gmbh/nuxt-image that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants