Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #99

Closed
wants to merge 75 commits into from
Closed

Dev #99

wants to merge 75 commits into from

Conversation

farnabaz
Copy link
Member

@farnabaz farnabaz commented Nov 16, 2020

close #80
close #82

@codecov-io
Copy link

codecov-io commented Nov 19, 2020

Codecov Report

Merging #99 (faf6ea1) into master (70c0e00) will decrease coverage by 16.92%.
The diff coverage is 54.20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #99       +/-   ##
===========================================
- Coverage   72.89%   55.97%   -16.93%     
===========================================
  Files          21       28        +7     
  Lines         557      670      +113     
  Branches      142      173       +31     
===========================================
- Hits          406      375       -31     
- Misses        151      295      +144     
Impacted Files Coverage Δ
src/runtime/meta.ts 0.00% <0.00%> (ø)
src/runtime/sizes.ts 0.00% <0.00%> (ø)
src/providers/local/runtime.ts 12.50% <12.50%> (ø)
src/runtime/utils.ts 55.81% <30.76%> (-41.33%) ⬇️
src/runtime/observer.ts 35.29% <35.29%> (ø)
src/runtime/image.ts 37.87% <43.10%> (-6.49%) ⬇️
src/runtime/components/nuxt-img.ts 44.77% <44.77%> (ø)
src/generate.ts 48.14% <48.14%> (ø)
src/runtime/components/nuxt-picture.ts 54.68% <54.68%> (ø)
src/providers/cloudinary/runtime.ts 69.23% <60.00%> (-30.77%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70c0e00...faf6ea1. Read the comment docs.

Alucard17 and others added 8 commits December 6, 2020 20:23
Co-authored-by: Karan yadav <alucard17>
Co-authored-by: Santosh Bhandari <bsantosh909@gmail.com>
Co-authored-by: Santosh Bhandari <bsantosh909@gmail.com>
Co-authored-by: Santosh Bhandari <bsantosh909@gmail.com>
Co-authored-by: Santosh Bhandari <bsantosh909@gmail.com>
Co-authored-by: Santosh Bhandari <bsantosh909@gmail.com>
@bsantosh909
Copy link
Contributor

Any updates on this ??

@NotHolst
Copy link

Did this PR die, or is there something we can do to help ?

@atinux atinux assigned pi0 and atinux Dec 22, 2020
Copy link
Member

atinux commented Dec 22, 2020

It is not, we are soon going to push the final touches for it, sorry for being long but this module is quite important and we want to make sure it is prepared for the long run 😊

@pi0
Copy link
Member

pi0 commented Dec 23, 2020

Main branch changed to dev for time being. Next release will be shortly after finishing last part of refactors (runtime/components) and doc update.

@pi0 pi0 closed this Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment