Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new extensions category and improve category assignments #75

Merged
merged 5 commits into from
Jan 12, 2021

Conversation

Geminii
Copy link
Collaborator

@Geminii Geminii commented Jan 9, 2021

Currently, some module aren't really Devtools module that help you only in dev, and things that just extend the capabilities of Nuxt. They aren't really dev-centric.
The proposed solution is to add a new category called Extensions to distinguish both.

  • waiting for default extensions icon

Devtools category will contain only : eslint, typescript, typescript-runtime, webpack-profile, ngrok, webpackmonitor, localtunnel, typed-router, bundle-buddy, webpackdashboard.

Do you think we need to add another module into Devtools category like python or others for example ?
@pi0

@pi0
Copy link
Member

pi0 commented Jan 11, 2021

Nice work @Geminii 👍 Modules like python might be moved to misc/miscellaneous category probably? Also shall we merge with devtool icon or you prefer waiting for icon?

@Geminii
Copy link
Collaborator Author

Geminii commented Jan 11, 2021

Nice work @Geminii 👍 Modules like python might be moved to misc/miscellaneous category probably? Also shall we merge with devtool icon or you prefer waiting for icon?

It might be wise to create a new miscellaneous category. Do you think that there would also be other modules that could fall into this category ? (maybe create a new PR for this one)

I would like to wait the icon because i know that rmoon will do a great job about it ❤️

@pi0
Copy link
Member

pi0 commented Jan 11, 2021

It might be wise to create a new miscellaneous category. Do you think that there would also be other modules that could fall into this category ? (maybe create a new PR for this one)

Actually python is only one i can think of as of now... Yet we need a cat for it

I would like to wait the icon because i know that rmoon will do a great job about it ❤️

That would be awesome then! Just didn't want to stall PR :)

modules/leaflet.yml Outdated Show resolved Hide resolved
modules/rfg-icon.yml Outdated Show resolved Hide resolved
modules/stories.yml Outdated Show resolved Hide resolved
modules/storybook.yml Outdated Show resolved Hide resolved
modules/svg-sprite.yml Outdated Show resolved Hide resolved
@atinux
Copy link
Member

atinux commented Jan 11, 2021

I believe we should merge Librairies and Extensions together and use the Librairies icon :)

@Geminii
Copy link
Collaborator Author

Geminii commented Jan 11, 2021

I believe we should merge Librairies and Extensions together and use the Librairies icon :)

It's a good alternative instead of to create a new Extensions category.
But about python, consider it as Libraries too ? or create a new Misc category ?

@pi0
Copy link
Member

pi0 commented Jan 11, 2021

@Geminii If only python is problematic, you may remove it since it is an unmaintained/experimental module anyway

@Geminii
Copy link
Collaborator Author

Geminii commented Jan 11, 2021

Thanks for all of your great feedbacks.
I will integrate them 😀

Copy link
Member

atinux commented Jan 11, 2021

Sorry I phrased it wrongly, what I meant is renaming Librairies to Extensions.

@pi0
Copy link
Member

pi0 commented Jan 11, 2021

renaming Librairies to Extensions

Current libraries are modules that integrate an exisisting Vue/JS library with Nuxt while extensions like nuxt story adding a new feature to nuxt DX / Build system.

Copy link
Member

atinux commented Jan 11, 2021

I think, makes perfect sense, so @nuxtjs/i18n should be moved into Librairies right?

modules/leaflet.yml Outdated Show resolved Hide resolved
modules/rfg-icon.yml Outdated Show resolved Hide resolved
modules/stories.yml Outdated Show resolved Hide resolved
modules/storybook.yml Outdated Show resolved Hide resolved
modules/svg-sprite.yml Outdated Show resolved Hide resolved
@atinux
Copy link
Member

atinux commented Jan 12, 2021

Updated the PR, it looks good for me: https://modules-of7rfl989.vercel.app/?orderBy=desc#Devtools

One note, should be move Storybook and Nuxt Stories to UI @pi0 ?

@pi0
Copy link
Member

pi0 commented Jan 12, 2021

Technically storybook is not a nuxt module :D BTW i think being in devtools at least currently makes more sense since UI section is used for UI frameworks or modules that add UI components. Storybook while can be used for production, is mainly a development tool...

modules/emotion.yml Outdated Show resolved Hide resolved
modules/emotion.yml Outdated Show resolved Hide resolved
@atinux
Copy link
Member

atinux commented Jan 12, 2021

Should be perfect now, Vincent will make a logo when he will have time, no need to wait for merging this PR I think :)

@pi0 pi0 changed the title feat(category): add new extensions category add new extensions category and improve category assignments Jan 12, 2021
@pi0 pi0 marked this pull request as ready for review January 12, 2021 14:24
modules/localforage.yml Outdated Show resolved Hide resolved
modules/localforage.yml Outdated Show resolved Hide resolved
@atinux atinux merged commit f9223ba into nuxt:master Jan 12, 2021
imgbot bot pushed a commit to rahulkumarsingh73690/modules that referenced this pull request Jan 21, 2021
…uxt#75)

* feat(category): add new extensions category

* chore: rename categories to suggested one

* chore: update to Librairies icon

* chore: Add back extensions to emotion-module

* chore: add Librairies to localForage

Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants