Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): fix a11y issues #220

Merged
merged 5 commits into from
Nov 12, 2021
Merged

fix(website): fix a11y issues #220

merged 5 commits into from
Nov 12, 2021

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Nov 12, 2021

  • Ensure color contrasts matching AAA (using this extension)
  • Allow clicking on modules in nav "Modules"
  • Fix sort drop down background
  • Make "[logo] Modules" in nav clickable
  • Replace .... with

Todo 1:

  • Color mode sets "system" as a preference. This makes issues when system theme is actually dark. We need to click twice to switch to light theme.
  • Color mode seems not restoring cookie state for server side-rendering

Todo 2:
I couldn't figure out for this situation that when a category is selected and clicked again, goes into a bad situation
image

@netlify
Copy link

netlify bot commented Nov 12, 2021

✔️ Deploy Preview for nuxt-modules ready!

🔨 Explore the source changes: baef6ad

🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt-modules/deploys/618ea390dfaa1e0008ea56d1

😎 Browse the preview: https://deploy-preview-220--nuxt-modules.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant