Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to nuxt 3 #297

Merged
merged 14 commits into from Feb 7, 2022
Merged

refactor: migrate to nuxt 3 #297

merged 14 commits into from Feb 7, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Feb 7, 2022

Disabled module:

If vue-plausible is strictly needed, I guess we could have an inline plugin to directly register it as a workaround.

@antfu antfu marked this pull request as draft February 7, 2022 04:42
@pi0
Copy link
Member

pi0 commented Feb 7, 2022

@antfu Neither are blockers IMO.

We could support nuxt3 for both modules later on. /cc @danielroe @moritzsternemann

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview looks working 💯 https://modules-4og32pd3b-nuxt-js.vercel.app/

Only there is a warning

@moritzsternemann
Copy link

I will start work on nuxt3 support for vue-plausible end of next week as I'm currently busy finishing up my bachelor's thesis 😇

Will let you know about the progress

@pi0
Copy link
Member

pi0 commented Feb 7, 2022

Thank you @moritzsternemann. Please don't hesitate to ping me if needed any help also good luck with your bachelor thesis 🤓

@antfu antfu merged commit 453e607 into main Feb 7, 2022
@antfu antfu deleted the feat/nuxt3 branch February 7, 2022 22:55
@toniengelhardt
Copy link

@antfu @pi0 @moritzsternemann not sure this is helpful, but the vue-plausible module seems to be working without problems in my Nuxt 3 project.

To trigger custom events I use this simple composable:

export const usePlausible: any = () => {
  const nuxtApp = useNuxtApp()
  return nuxtApp.$plausible
}

and then just:

const plausible = usePlausible()
plausible.trackEvent('some event', { props: { ... } })

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants