Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): support type auto-import #18859

Merged
merged 2 commits into from
Feb 7, 2023
Merged

feat(nuxt): support type auto-import #18859

merged 2 commits into from
Feb 7, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Feb 7, 2023

πŸ”— Linked issue

fix #12808

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently only adding entries from Vue. /cc @danielroe do you see any other types we could like to auto-import from Nuxt?

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Feb 7, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@antfu antfu requested a review from danielroe February 7, 2023 13:53
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. I don't think auto-importing Nuxt types (e.g. NuxtApp) is needed for now, as many of these aren't utility types but for more advanced use-cases. Of course we can revisit if there's a need.

@danielroe danielroe changed the title feat: support type auto-import feat(nuxt): support type auto-import Feb 7, 2023
@danielroe danielroe merged commit 2677b88 into main Feb 7, 2023
@danielroe danielroe deleted the feat/types-auto-import branch February 7, 2023 14:00
@danielroe danielroe mentioned this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto import for types like Ref
2 participants