fix(vite): avoid serving arbitrary file in vite-node middleware #20345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pi0
reviewed
Apr 18, 2023
| return false | ||
| } | ||
|
|
||
| function isParentDirectory (dir: string, file: string): boolean { |
There was a problem hiding this comment.
Would be happy to see such utils going to pathe/utils would be much easier to share and also test...
antfu
commented
Apr 18, 2023
Comment on lines
+187
to
+190
| /** | ||
| * The following code is ported from vite | ||
| * Awaits https://github.com/vitejs/vite/pull/12894 | ||
| */ |
There was a problem hiding this comment.
@pi0 I'd suggest we do nothing about the code below and wait for the Vite PR to be shipped (so we could remove them). Unless you are saying it could be a nice addition to pathe but not related to this PR.
There was a problem hiding this comment.
Not specific for this PR of course. And only if finally vite can leverage from same util. Otherwise closest impl is best.
danielroe
approved these changes
Apr 18, 2023
Merged
8 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Code ported from Vite, await vitejs/vite#12894 to refactor.
❓ Type of change
📚 Description
📝 Checklist